fix: extend http download timeout #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Sep 28, 2023
| @@ -91,6 +91,10 @@ func (s *DownloadService) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| // if the buffer contains the actual data we expect we proceed with sending it to the browser | |||
| // Set headers | |||
| w.Header().Set("Content-Disposition", fmt.Sprintf("attachment; filename=%s", info.FileName)) | |||
There was a problem hiding this comment.
this has been moved to just notify the browser early of what to expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in fact is a misconfiguration in the helm Chart and only Azure Blob Storage is affected.
The reason Azure is the only affected is because in its implementation we in fact use the parent
contextwhich by default has atimeout. The OCI implementation doesn't use context (it should)The reason it only affects the HTTP endpoint is because grpc downloads don't have timeouts, http one does.
Fixes #366