feat(CAS): AWS S3 blob storage support #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmartri
commented
Oct 16, 2023
danlishka
approved these changes
Oct 16, 2023
| @@ -84,7 +84,8 @@ func resourceName(digest string) string { | |||
| // Exists check that the artifact is already present in the repository | |||
| func (b *Backend) Exists(ctx context.Context, digest string) (bool, error) { | |||
| _, err := b.Describe(ctx, digest) | |||
| if err != nil && errors.As(err, &backend.ErrNotFound{}) { | |||
| notFoundErr := &backend.ErrNotFound{} | |||
| if err != nil && errors.As(err, ¬FoundErr) { | |||
There was a problem hiding this comment.
can you please provide more info why this change here?
There was a problem hiding this comment.
The context is that this wasn't working before, as the error wasn't cast properly. I noticed it because of the tests in AWS which hit a similar code.
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for AWS S3 as Content Addressable Storage.
NOTE: The implementation is very similar to the Azure one #357. The main enhancement in this case in comparison to Azure is that we can rely on sha256 integrity verification on their side easily.
Register storage backend in your Control plane
and metadata set
Closes #269