Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflows): Integrate GitHub Release reusable workflow #851

Merged
merged 5 commits into from
May 30, 2024
Merged

feat(workflows): Integrate GitHub Release reusable workflow #851

merged 5 commits into from
May 30, 2024

Conversation

javirln
Copy link
Member

@javirln javirln commented May 30, 2024 •
edited

This patch removes custom release logic to leverage the changes on the GitHub Release reusable workflow from labs.

Changes:

  • Modified permissions since the underlaying job needs write permission because we are changing the release notes with the attestation link.
  • Pass container images as additional materials interpolating the release tag

Refs #785

@javirln
feat(workflows): Integrate GitHub Release reusable workflow
9a78fa3 
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln
remove dependency
7000730 
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln
Update labs reference
d9cefcc 
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln javirln requested review from migmartri and jiparis May 30, 2024 10:06
@javirln javirln marked this pull request as ready for review May 30, 2024 10:09
@javirln javirln changed the title WIP feat(workflows): Integrate GitHub Release reusable workflow feat(workflows): Integrate GitHub Release reusable workflow May 30, 2024
@javirln
Change job name
94010aa 
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln
Update reference to labs project
00b4256 
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln javirln merged commit b92d97f into main May 30, 2024
13 checks passed
@javirln javirln deleted the feat/785-integrate-reusable-workflow branch May 30, 2024 10:55
javirln added a commit that referenced this pull request May 30, 2024
@javirln
Revert "feat(workflows): Integrate GitHub Release reusable workflow (#…
56e562e 
…851)"

This reverts commit b92d97f.

Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
migmartri pushed a commit that referenced this pull request May 30, 2024
@javirln
Revert "feat(workflows): Integrate GitHub Release reusable workflow (#…
f81a43e 
…851) (#857)

Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migmartri migmartri Awaiting requested review from migmartri

@jiparis jiparis Awaiting requested review from jiparis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@javirln