fix(attestation): push on dry-run #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Jun 10, 2024
| @@ -81,6 +81,10 @@ func newAttestationInitCmd() *cobra.Command { | |||
| return newGracefulError(err) | |||
| } | |||
|
|
|||
| if res.DryRun { | |||
| logger.Info().Msg("The attestation is being crafted in dry-run mode. It will not get stored once rendered") | |||
There was a problem hiding this comment.
this is just removing the dry-run output from stdout and move it to stderr as we are doing lately in the rest of the code.
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem while trying to
att pushan attestation that was initialized indry-runmode. The validation error wasThis patch skips that schema validation when running in
dry-runmode since in this mode it's know to not to be fully complete.refs #796