Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feature ] Pytorch Model to NCNN Model #235

Closed
iwubcode opened this issue May 16, 2022 · 1 comment · Fixed by #721 or #824
Closed

[ Feature ] Pytorch Model to NCNN Model #235

iwubcode opened this issue May 16, 2022 · 1 comment · Fixed by #721 or #824
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@iwubcode
Copy link

As an AMD user, the automatic conversion from the pytorch model format to ncnn is really nice to have in cupscale. For now I can use that tool and use any converted models in chaiNNER but it would nice to support something similar natively in chaiNNER.

I know this was in the readme but I wanted to capture it as an issue so someone would be more likely to work on it :)

@joeyballentine
Copy link
Member

I was working on this in the past but wasn't able to get the package working quite right for it. It's difficult to get it working for Linux specifically.

I'll come back to it at some point.

The issue is just that conversion from pytorch to ncnn isn't that simple, and the code that allows easy conversion isn't for python. So, the solution is to use temp files and the precompiled binaries (which is what cupscale does). The issue with this though is chainner supports more than just windows, which makes that kind of thing far more difficult thanks to all the varieties of Linux (and especially the pypi requirements to get a package published).

So, it'll be done at some point, but I don't know when.

@joeyballentine joeyballentine added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 16, 2022
@joeyballentine joeyballentine mentioned this issue Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants