Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a test suite to test the bots response to different inputs #22

Open
umar-ahmed opened this issue Apr 20, 2023 · 2 comments
Open
Labels
help wanted Extra attention is needed

Comments

@umar-ahmed
Copy link
Collaborator

umar-ahmed commented Apr 20, 2023

  • /report & /check
    • Invalid URL
    • URLs for Pages instead of domains
    • URL that's too long

I don't really know what people use to test Discord bots, but I imagine you'd need to start up the bot client in a non-agent mode so that it can respond directly to mocked HTTP requests rather than connecting to Discord's servers.

@umar-ahmed umar-ahmed added the help wanted Extra attention is needed label Apr 20, 2023
@MaXeraph
Copy link
Contributor

MaXeraph commented May 7, 2023

  • URLs for Pages instead of domains
  • URL that's too long

How are these being validated? I dont think they are currently in the discord bot.

@umar-ahmed
Copy link
Collaborator Author

  • URLs for Pages instead of domains
  • URL that's too long

How are these being validated? I dont think they are currently in the discord bot.

@MaXeraph I put those as examples because I thought those were things we'd add to the bot at some point. But for the purposes of the ticket mainly I want to set up the test infra itself. Maybe with just one test that asserts that the /asset/check API is called with some params + mock out the response.

MaXeraph added a commit to MaXeraph/discord-bot that referenced this issue May 11, 2023
MaXeraph added a commit to MaXeraph/discord-bot that referenced this issue May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants