This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
Add support for setting configs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacohend @jasonbukowski - Pretty simple update but might be useful for broadening ways to pass configs in other modules as per some discussion offline with @jacohend. Tests should hopefully give an idea of how to set and get configs with bcfg. |
…th Promise.all and enabling timeouts for fetch in browser
|
Going to merge these in. Let me know if there are any questions about the config tooling! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements bcfg for handling config parsing adding the ability to set configs by passing in an options object, using a config file, env vars prefaced with
CHAINPOINT_or passing via argv in command line.This PR also uses this new interface for passing two values that are available as constants in the code base and instead uses those constants as a fallback.