fix spot sdot overflow (paritytech#616)

chainx-org · May 16, 2019 · eedcc53 · eedcc53
1 parent d1a9f93
commit eedcc53
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/rpc/src/chainx/impl_rpc.rs b/rpc/src/chainx/impl_rpc.rs
@@ -560,9 +560,12 @@ where
                         if !handicap.lowest_offer.is_zero() {
                             info.maximum_bid = handicap.lowest_offer + pair.fluctuation();
                         }
-                        if !handicap.highest_bid.is_zero() {
+                        if handicap.highest_bid > pair.fluctuation() {
                             info.minimum_offer = handicap.highest_bid - pair.fluctuation();
+                        }else {
+                            info.minimum_offer =  10_u64.pow(pair.tick_precision);//tick
                         }
+
                     }
 
                     pairs.push(info);
@@ -642,10 +645,11 @@ where
                     lowest_offer + pair.fluctuation()
                 };
 
-                let minimum_offer = if highest_bid.is_zero() {
-                    0
-                } else {
+                let minimum_offer = if highest_bid > pair.fluctuation() {
                     highest_bid - pair.fluctuation()
+                } else {
+                    10_u64.pow(pair.tick_precision)
+
                 };
 
                 for price in (lowest_offer..=maximum_bid).step_by(tick as usize) {

diff --git a/runtime/wasm/target/wasm32-unknown-unknown/release/chainx_runtime.compact.wasm b/runtime/wasm/target/wasm32-unknown-unknown/release/chainx_runtime.compact.wasm
diff --git a/xrml/xdex/spot/src/manager/mod.rs b/xrml/xdex/spot/src/manager/mod.rs
@@ -49,7 +49,7 @@ impl<T: Trait> Module<T> {
                     fluctuation
                 );
 
-                if lowest_offer.is_zero() {
+                if highest_bid.is_zero() {
                     return Ok(());
                 }