Add a new error code for invalid scenario #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if we send a scenario id but that ID is not in the available cache data, we return the error MISSING_SCENARIO, which is missleading. We add a new error code INVALID_SCENARIO, that will be returned if the scenario_id is not a valid uuid, or it's not present in our data source Fixes: chairemobilite#295
tahini
approved these changes
Jun 12, 2024
|
When you merge, please add an issue in Transition to support this return value |
Will do. Transition should never gets this error, so we'll need to make it quite apparent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we send a scenario id but that ID is not in the available cache data, we return the error MISSING_SCENARIO, which is missleading.
We add a new error code INVALID_SCENARIO, that will be returned if the scenario_id is not a valid uuid, or it's not present in our data source
Fixes: #295