batchRoute: Refactor result handling #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaligrafy
approved these changes
Mar 16, 2023
More arguments will be added to support checkpointing the batch calculation task. Instead of ordered arguments, we put them in a single options argument.
Extract the function that gets the csv attributes to a `ResultAttributes.ts` file, to make sure the result object is always identical for a given calculation and does not change in one place, without updating the other.
Similar to the accessibility map result processor, the result processing for batch routing is extracted to a Result class, which handles the file creation, update and ending.
This moves the batch routing execution in a class, where the main function can be more easily split into smaller chunks, using class fields, easier to maintain and enhance.
tahini
force-pushed
the
batchRouteResultRefactoring
branch
from
8eeb4a7
to
0c03938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work to handle checkpoints and job resume, this extracts the result handling to its own class, like it is already done in the batch accessibility map calculation.
The main batchRoute method is refactored to be handled by a class, with parameters and options as local fields, that can more easily be split in modular chunks