Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xml object refactor #12

Closed
2 tasks done
chajr opened this issue Sep 29, 2014 · 0 comments
Closed
2 tasks done

Xml object refactor #12

chajr opened this issue Sep 29, 2014 · 0 comments
Labels
enhancement
Milestone
version 0.1.0

Comments

@chajr
Copy link
Owner

chajr commented Sep 29, 2014

some refactor changes for method

  • return $this statement
  • return as string method
@chajr chajr added this to the version 0.1.0 milestone Oct 1, 2014
chajr added a commit that referenced this issue Oct 3, 2014
@chajr
Xml object refactor (issue #12)
96f3488 
This version introduces multiple enhancements:

refactored some methods and added new one

Details of additions/deletions below:
--------------------------------------------------------------

Modified:   Data/Xml.php
            -- Added --
                hasErrors
                clearErrors
                getError
                __toString
            -- Updated --
                $err renamed to $_error
                $idList renamed to $_idList
                $_options added default values
                loadXmlFile $err renamed to $_error
                saveXmlFile $err renamed to $_error
                getFreeId $idList renamed to $_idList and femoved final keyword
                _searchByAttribute changed from private to protected
                checkId removed final keyword

Modified:   Base/BlueObject.php
            -- Updated --
                toXml changes after refactor, handle errors from Xml object
@chajr chajr closed this as completed Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
version 0.1.0
Development

No branches or pull requests
1 participant
@chajr