Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the case of the number of male/female executive is zero #2

Merged

Conversation

peisuke
Copy link
Contributor

@peisuke peisuke commented Jan 29, 2020

Fixed the problem of the title.

Before adding the value, the new codes checks the type.

@peisuke peisuke changed the title fix the case of the number of male/female executive is zero #1 fix the case of the number of male/female executive is zero Jan 29, 2020
@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #2 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   91.97%   91.98%   +<.01%     
==========================================
  Files          27       27              
  Lines        1084     1085       +1     
==========================================
+ Hits          997      998       +1     
  Misses         87       87
Impacted Files Coverage Δ
xbrr/edinet/reader/aspects/information.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aae86c...dcb3294. Read the comment docs.

@icoxfog417
Copy link
Member

Thank you! I want to support Kanji number someday.

@icoxfog417 icoxfog417 merged commit 33df977 into chakki-works:master Jan 29, 2020
@icoxfog417 icoxfog417 mentioned this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants