Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified test: Xplat Debug only Recycler crash on exit #5636

Open
rhuanjl opened this issue Aug 25, 2018 · 1 comment
Open

Modified test: Xplat Debug only Recycler crash on exit #5636

rhuanjl opened this issue Aug 25, 2018 · 1 comment
Labels
Test Bug

Comments

@rhuanjl
Copy link
Collaborator

rhuanjl commented Aug 25, 2018 •
edited

See these comments:
#5622 (comment)
#5622 (comment)

After implementing Object.fromEntries the AsmJS parameters out of memory test would crash on xplat debug builds when calling WScript.Quit(0) - this issue only repros on xplat debug builds and seemingly only with fatal errors for OOM disabled (which this test disabled).

Fixed the test for now by avoiding the use of WScript.Quit - as that's not what the test was actually meant to test but there is a bug here that should be looked into.

CC @MikeHolman
@rhuanjl rhuanjl mentioned this issue Aug 25, 2018
Merged
@rhuanjl rhuanjl changed the title Modified test: Xplat Debug only Recycler crash on Modified test: Xplat Debug only Recycler crash on exit Aug 25, 2018
@kfarnung
Copy link
Contributor

kfarnung commented Sep 5, 2018

@MikeHolman Can you triage this bug?

rhuanjl added a commit to rhuanjl/ChakraCore that referenced this issue Feb 1, 2021
@rhuanjl
Revert edit to test, fix chakra-core#5636
a9642db
@rhuanjl rhuanjl mentioned this issue Feb 1, 2021
Closed
rhuanjl added a commit to rhuanjl/ChakraCore that referenced this issue Feb 1, 2021
@rhuanjl
Revert edit to test, fix chakra-core#5636
8952010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Test Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trivial: Revert test edit rhuanjl/ChakraCore
2 participants
@kfarnung @rhuanjl