WebAssembly i32.popcnt + tests #1459
Conversation
|
|
|
FYI @Cellule. You guys might want to work out how to handle merging this, since your int64 change has some of this already (implemented slightly differently) |
|
@MikeHolman can you please help to sign off this change on the signing tool as well. |
|
@arunetm Done. |
| <default> | ||
| <files>i32_popcnt.js</files> | ||
| <baseline>i32_popcnt.baseline</baseline> | ||
| <compile-flags>-on:Wasm -maic:0</compile-flags> |
There was a problem hiding this comment.
this test is not needed as rl.exe will run a the other one with -forcenative
There was a problem hiding this comment.
@Cellule right :-) let me update the PR
|
The int64 change will come later so I will take care of resolving conflicts, it should not be too bad as I hadn't done the codegen part. |
|
@MikeHolman @Cellule, this is something i think i should prlly mention. |
|
@Krovatkin I wouldn't worry about inlining, LTCG should take care of this just fine. But still good to hear confirmation. |
refining asserts, removing nop fixing whitespace adding a copyright header popcnt32 rename remove extern moving popcnt32 to math removing codegen test
Krovatkin
force-pushed
the
wasm_popcnt32
branch
from
2f43f87
to
e51083a
Compare
|
LGTM |
Merge pull request #1459 from Krovatkin:wasm_popcnt32 interpreter and codegen implementations for i32.popcnt fyi: @commonlisp @arunetm @cellulle @MikeHolman homeless PR looks for a nice review and branch to be adopted into
interpreter and codegen implementations for i32.popcnt fyi: @commonlisp @arunetm
@cellulle @MikeHolman homeless PR looks for a nice review and branch to be adopted into