Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library bytecode verification unittests #1505

Closed
wants to merge 1 commit into from

Commits on Aug 30, 2016

  1. Library bytecode verification unittests

    Reintroduces bytecode verification unittests for library code. We previously had this check in SD days, but it was complicated and called external scripts to work. The new version uses just RL to compare against the header file directly. A number of changes had to be made:
    
    - Removed non-standard %REGRESS% psuedo environment variable. Instead, test files and baselines are relative paths based on the directory containing the rlexe.xml.
    - Fixed the relative path behavior of runtests.py. Also added a guard to the timezone set so runtests.py works on Windows again.
    - Fixed an issue where ch would generate different bytecode than jshost due to an implicit fscrNoAsmJs parser flag in ScriptContext. We don't need this flag on the initial entry, so it can be removed from the JSRT entrypoint for library bytecode generation.
    - Disabled using the release version for serialized library bytecode, instead using a fixed version (all 0's). This is OK as long as we check the bytecode integrity in unit tests.
    - Added an implicit disable_jit tag exclusion when not running disable JIT; this allows us to run some test only under disable JIT and not normally.
    - Added a new bytecode directory with the xml for the tests.
    
    Due to the changes to serialization all of the library bytecode headers needed to be changed.
    tcare committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    13294ba View commit details
    Browse the repository at this point in the history