Use the error HR for the exception code for debug attach/detech fatal error #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yongqu @agarwal-sandeep Review please. |
| { | ||
| Debugger_AttachDetach_fatal_error(); // Inconsistent state, we can't continue from here | ||
| Debugger_AttachDetach_fatal_error(hr); // Inconsistent state, we can't continue from here | ||
| return JsErrorFatal; |
There was a problem hiding this comment.
return JsErrorFatal; [](start = 16, length = 20)
We won't reach here ever, can be simplified as Debugger_AttachDetach_fatal_error(scriptContext->OnDebuggerDetached())?
There was a problem hiding this comment.
Well, Debugger_AttachDetach_fatal_error doesn't check hr, and it can be in one line.
I'd rather save the sorry by returning....
|
Otherwise LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Aug 30, 2016
…debug attach/detech fatal error Merge pull request #1509 from curtisman:hr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.