ChakraFull/ChakraCore Intl.js bytecode parity #1520
Conversation
|
@curtisman @MikeHolman please review |
| @@ -418,33 +419,57 @@ class ByteCodeBufferBuilder | |||
| } | |||
|
|
|||
| // library alaways use the release versioning scheme | |||
|
Please also regen Intl.js.nojit.bc.32b.h (you only regen'd Intl.js.nojit.bc.64b.h for NoJIT) Also just to be sure everything is good, when you're ready, please run the NoJIT tests: https://github.com/Microsoft/ChakraCore/wiki/Jenkins-Build-Triggers#disablejit-builds |
|
LGTM |
This is a precursor to bytecode verification unit tests, which requires ChakraFull to produce the same library bytecode as ChakraCore for Intl.js. - Removed an implicit fscrNoAsmJs parser flag in ScriptContext when entering from JSRT. We don't need this flag on the initial entry, so it can be removed from the JSRT entrypoint for library bytecode generation. - Zero out bytecode version when generating library bytecode.
|
@dotnet-bot test nojit tests please |
|
Ping... I couldn't repro the disablejit problems, trying again. @dotnet-bot test nojit tests please |
|
@tcare looks good now. Not sure what happened before... |
| @@ -1700,7 +1700,7 @@ if (!sourceList) | |||
|
|
|||
| if((loadScriptFlag & LoadScriptFlag_isByteCodeBufferForLibrary) == LoadScriptFlag_isByteCodeBufferForLibrary) | |||
| { | |||
| grfscr |= (fscrNoAsmJs | fscrNoPreJit); | |||
There was a problem hiding this comment.
Why is this change required? Rest of the changes changes look good.
There was a problem hiding this comment.
grfscr gets encoded into library bytecode as part of function body. We don't set it in JsHost, so we don't need to set it in ch either (checked with @MikeHolman)
|
|
Merge pull request #1520 from tcare:bcser This is a precursor to bytecode verification unit tests, which requires ChakraFull to produce the same library bytecode as ChakraCore for Intl.js. - Removed an implicit fscrNoAsmJs parser flag in ScriptContext when entering from JSRT. We don't need this flag on the initial entry, so it can be removed from the JSRT entrypoint for library bytecode generation. - Zero out bytecode version when generating library bytecode.
This is a precursor to bytecode verification unit tests, which requires ChakraFull to produce the same library bytecode as ChakraCore for Intl.js.