WASM.SIMD Use appropriate overloads (matching lane width) of CanonicalizeToBools #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious, do you know why this was okay in ch.exe, but not in jshost.exe ? |
|
@Cellule there are no simd.js tests (only asm.js ones) for Bool8x16/Bool16x8.AllTrue in ChakraCore's test suite. |
|
@Cellule alright, we're all green here! :-) Could you please help us to merge this? |
Krovatkin
changed the title
chakrabot
pushed a commit
that referenced
this pull request
Jul 13, 2017
…g lane width) of CanonicalizeToBools Merge pull request #3342 from Krovatkin:wasm.simd.compops This should fix failures in SIMD.validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix failures in SIMD.validation