[MSFT 12313182] Detect assignment to const in nested functions that were originally deferred. #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/Runtime/ByteCode/ScopeInfo.h
Outdated
| @@ -29,6 +29,7 @@ namespace Js { | |||
| Field(SymbolType) symbolType; | |||
| Field(bool) hasFuncAssignment; | |||
| Field(bool) isBlockVariable; | |||
| Field(bool) isConst; | |||
| Field(bool) isFuncExpr; | |||
| Field(bool) isModuleExportStorage; | |||
| Field(bool) isModuleImport; | |||
There was a problem hiding this comment.
Can we make these bit fields. Saves 4 bytes on x86.
…ere originally deferred. Add symbol-is-const flag to Symbol and to ScopeInfo to allow us to detect this case. Don't rely on having access to a parse node for the declaration.
chakrabot
pushed a commit
that referenced
this pull request
Sep 6, 2017
…ested functions that were originally deferred. Merge pull request #3645 from pleath:12313128 Add symbol-is-const flag to Symbol and to ScopeInfo to allow us to detect this case. Don't rely on having access to a parse node for the declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add symbol-is-const flag to Symbol and to ScopeInfo to allow us to detect this case. Don't rely on having access to a parse node for the declaration.