OS#13255723, OS#13255732, OS#13255734, OS#13255735, OS#13255737: A few more uninitialized locals. #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w more uninitialized locals. Fixed a few more benign cases.
| @@ -178,7 +178,7 @@ void IntBounds::SetBound( | |||
|
|
|||
| // Aggressively merge the constant lower or upper bound of the base value, adjusted by the offset | |||
| ValueInfo const * const baseValueInfo = baseValue->GetValueInfo(); | |||
| int constantBoundBase; | |||
| int constantBoundBase = 0xCCCCCCCC; | |||
There was a problem hiding this comment.
0xCCCCCCCC [](start = 28, length = 10)
Why these value?
There was a problem hiding this comment.
I couldn't find a default that made sense for these. 0 is often a bad choice, MIN/MAX_INT were not great.
0xCCCCCCCC has a few good properties:
o Negative
o Bad pointer
o INT 3 on x86/x64
o Easy to spot in the debugger
o That's what VC uses to initialize the stack with -RTC1
agarwal-sandeep
approved these changes
Sep 6, 2017
chakrabot
pushed a commit
that referenced
this pull request
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few more benign cases.