[CVE-2018-0818] Add ProcessContexts for OOP JIT #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leirocks
reviewed
Dec 14, 2017
lib/JITServer/JITServer.cpp
Outdated
| ServerContextManager::RegisterThreadContext(contextInfo); | ||
| } | ||
| catch (Js::OutOfMemoryException) | ||
| { | ||
| CloseHandle(targetHandle); | ||
| if (!contextInfo) |
There was a problem hiding this comment.
contextInfo [](start = 13, length = 11)
if there's OOM after HeapNew, we should free contextInfo
if it's not possible to OOM after HeapNew, the we don't need the check here
leirocks
reviewed
Dec 14, 2017
lib/JITServer/JITServer.cpp
Outdated
| ProcessContexts.Add(pid, context); | ||
| } | ||
| catch (Js::OutOfMemoryException) | ||
| { |
There was a problem hiding this comment.
need to free context if OOM in ProcessContexts.Add()
leirocks
reviewed
Dec 14, 2017
lib/JITServer/JITServer.cpp
Outdated
| { | ||
| ProcessContext* context = iter.CurrentValue(); | ||
| // We can delete a ProcessContext if no ThreadContexts refer to it and the process is terminated | ||
| if (!context->HasRef() && WaitForSingleObject(context->processHandle, 0) != WAIT_TIMEOUT) |
There was a problem hiding this comment.
WAIT_TIMEOUT [](start = 84, length = 12)
use WAIT_OBJECT_0 instead? other than time out, wait function can have other failure
chakrabot
pushed a commit
that referenced
this pull request
Dec 15, 2017
Merge pull request #4427 from MikeHolman:oopprocessinit Adds early handshake to pass in runtime process addresses, with the assurance that this handshake is only done once per runtime process. OS:14980597
chakrabot
pushed a commit
that referenced
this pull request
Dec 15, 2017
Merge pull request #4427 from MikeHolman:oopprocessinit Adds early handshake to pass in runtime process addresses, with the assurance that this handshake is only done once per runtime process. OS:14980597
MikeHolman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds early handshake to pass in runtime process addresses, with the assurance that this handshake is only done once per runtime process.
OS:14980597