docs: documenting data-attributes #2121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FilipePfluck
changed the title
|
I'll be doing this bit by bit whenever I get some time. In the meanwhile I think the components I already documented can be reviewed, I may have missed some data-attributes. If I got something wrong go ahead and correct me. |
|
Thanks for working on this. After reviewing this closely, I've decided to automate it with a script in Zag.js. See the code here: chakra-ui/zag@9b379db This will make sure it's always in sync with the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds documentation for the data-attributes of the Accordion component. Please tell me if this format is ok and if I can do the same thing for the rest of the components. Also let me know if I missed any data-attribute