fix: narrow theme types for defaultProps and ComponentMultiStyleConfig

chakra-ui · Feb 6, 2021 · f3ba8dd · f3ba8dd
1 parent 30d8a81
commit f3ba8dd
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/.changeset/tricky-beers-smell.md b/.changeset/tricky-beers-smell.md
@@ -0,0 +1,7 @@
+---
+"@chakra-ui/react": patch
+"@chakra-ui/theme": patch
+---
+
+Fixed an issue where the TypeScript types were too narrow for component
+defaultProps and ComponentMultiStyleConfig
diff --git a/packages/react/tests/extend-theme.test.tsx b/packages/react/tests/extend-theme.test.tsx
@@ -90,6 +90,20 @@ describe("extendTheme", () => {
     expect(Object.keys(solidStyles).length).toBeGreaterThan(1)
   })
 
+  it("should be able to extend a multipart component", () => {
+    const override: ThemeOverride = {
+      components: {
+        Textarea: {
+          defaultProps: {
+            focusBorderColor: "green.200",
+          },
+        },
+      },
+    }
+
+    extendTheme(override)
+  })
+
   it("should pass typescript lint with random custom theme", () => {
     const override = {
       shadows: {

diff --git a/packages/theme/src/theme.types.ts b/packages/theme/src/theme.types.ts
@@ -33,7 +33,7 @@ export interface ColorHues {
 
 export type ThemeDirection = "ltr" | "rtl"
 
-interface ComponentDefaultProps {
+interface ComponentDefaultProps extends Record<string, any> {
   size?: string
   variant?: string
   colorScheme?: string
@@ -51,7 +51,7 @@ export interface ComponentSingleStyleConfig {
 }
 
 export interface ComponentMultiStyleConfig {
-  parts: string[]
+  parts?: string[]
   baseStyle?: ThemeThunk<SystemStyleObjectRecord>
   sizes?: SystemStyleObjectRecord
   variants?: SystemStyleObjectRecord