Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Avatar] does not allow loading prop for underlying img #2150

Closed
ljosberinn opened this issue Oct 2, 2020 · 1 comment · Fixed by #2153
Closed

[Avatar] does not allow loading prop for underlying img #2150

ljosberinn opened this issue Oct 2, 2020 · 1 comment · Fixed by #2153
Labels
good first issue 👍 Good for newcomers Topic: Component API ⚙️ Issues or PR about a specific Chakra component API Type: Bug 🐛 Something isn't working

Comments

@ljosberinn
Copy link
Contributor

Bug report

already exists on Image and Img

image

Expected behavior

Avatar supports loading and passes the prop onto the internally used AvatarImage.

Docs should contain a hint about it, too.
@ljosberinn ljosberinn added Type: Bug 🐛 Something isn't working good first issue 👍 Good for newcomers Topic: Component API ⚙️ Issues or PR about a specific Chakra component API labels Oct 2, 2020
@Zaynex Zaynex mentioned this issue Oct 3, 2020
Merged
11 tasks
@Zaynex
Copy link
Contributor

Zaynex commented Oct 3, 2020

🔧

@with-heart with-heart linked a pull request Oct 4, 2020 that will close this issue
fix(avatar): add loading prop for avatar #2153
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 👍 Good for newcomers Topic: Component API ⚙️ Issues or PR about a specific Chakra component API Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(avatar): add loading prop for avatar Zaynex/chakra-ui
2 participants
@Zaynex @ljosberinn