feat(number-input): uses props of wrapping form-control

[silltho]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes
  /start features)

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Fixes: #804

What is the new behavior?

FormControl propagates props down to NumberInput children.

Does this introduce a breaking change?

• Yes
• No

Other information

I couldn't find any tests between FormControl and Select. So do i have to test the composition between FormControl and NumberInput?

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/qerdl788m
✅ Preview: https://chakra-ui-git-feat-number-input.chakra-ui.now.sh

[silltho]

anything i can do to get this merged ?

[ljosberinn]

@silltho sorry we've been quite busy, I personally haven't taken a look but we'll get to it shortly :)

[silltho]

Ok it's now been open for over 2 weeks. I know you guys are having a lot of work but still that's not developer friendly. A lot of other PRs being merged during this time and this is a really small one. However I keep this PR open but will not be available for doing any merge/rebase or change.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9337691

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@chakra-ui/number-input	Patch
@chakra-ui/docs	Patch
@chakra-ui/react	Patch
@chakra-ui/test-utils	Patch
chakra-cra	Patch
chakra-nextjs	Patch
chakra-nextjs-ts	Patch
@chakra-ui/props-docs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[with-heart]

@silltho You're absolutely right. Allowing a PR from the community to sit for so long without being reviewed or merged is something I consider to be a failure on our part. We were dealing with 1.0 focus, multiple team members being rather busy at work, and speaking for myself quite a bit of burnout, but those aren't good excuses when other work was still being merged. We will do better in the future.

In the meantime, I rebased this PR with changes from develop, cleaned up the merging of props from useFormControl, and added a test for use of NumberInput with a wrapping FormControl. If a reviewer could please give this a look, I think it'd be great to get this merged.

@allcontributors please add @silltho for code

[allcontributors]

@with-heart

I've put up a pull request to add @silltho! 🎉

[TimKolberger]

Looks good to me! Love the clean prop getter function 💖