New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(divider): add ability to style divider component with theme api #2478
fix(divider): add ability to style divider component with theme api #2478
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/5c2gkoc7y |
@with-heart , @ryanerras this addresses #2405 Someone familiar with the build might need to have a look at the build thought as |
🦋 Changeset detectedLatest commit: 55524df The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Zyclotrop-j for this PR 💖
I added a comment regarding the versioning. The code looks good to me!
.changeset/sharp-tables-change.md
Outdated
@@ -0,0 +1,6 @@ | |||
--- | |||
"@chakra-ui/layout": patch | |||
"@chakra-ui/theme": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a minor bump for both packages, because this PR adds a feature. Adding something increments in semver terms the minor version.
"@chakra-ui/layout": minor
"@chakra-ui/theme": minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "minor"
.changeset/sharp-tables-change.md
Outdated
"@chakra-ui/theme": patch | ||
--- | ||
|
||
fix(divider): add ability to style divider component with theme api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feat(divider): add ability to style divider component with theme api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "feat"
Rename the story from 'WidthStory' to 'DashedVariant' to clarify what it actually showcases
@TimKolberger , I added/cahnged the requested changes - please -re-review and let me know if there's anything else you'd like/prefer to be changed. And thanks for reviewing! |
@allcontributors please add @Zyclotrop-j for code |
I've put up a pull request to add @Zyclotrop-j! 🎉 |
Pull request checklist
Please check if your PR fulfills the following requirements:
/start features)
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Fixes: 2405
Divider component cannot be styled using the theme API.
What is the new behavior?
opacity
andborderColor
to themeExample:
The following is now possible (compare with comment on issue 2405 ;) ):
Does this introduce a breaking change?
Other information
This PR fixes only the Divider-theme-API styling bug, not the container-theme-API styling bug (both are grouped in 2405)!