Fixes gatsby-plugin-chakra-ui transpilation errors #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2019
Closed
|
Hey @alexlbr, thank you so much for the PR. So just to clarify, for plugin authors, we should always transpile |
|
@alexluong official Gatsby plugins are transpiled e.g. https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-link/.babelrc. I would personally transpile any package of any project that goes to npm because we don't know where and how it will be run |
|
Thank you for this PR @alexlbr. @alexluong can you confirm this is ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue gatsbyjs/19042
The problem is the plugin is not transpiled before being published to npm.
With this PR the code will be transpiled before publishing as follows:
