Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtl-feature): apply fixes for several components on RTL #2918

Merged
merged 16 commits into from
Jan 3, 2021

Conversation

MohamedSayed008
Copy link
Contributor

Closes #

📝 Description

Fix few components to be RTL friendly.

⛳️ Current behavior (updates)

  • stack spacing for right and left isn't working as expected.
  • borderStartStyle , borderEndStyle, borderStartColor, borderEndColor doesn't exist in props.
  • Close button for tag , modal , drawer doesn't flip with direction.
  • icon spacing for list isn't RTL friendly

🚀 New behavior

Fix alignment for Stack on RTL
Add Missing borderStart borderEnd for Style and Color
Close button alignment for tag , modal , drawer is RTL friendly now
Icon alignment for list
sort Object.assign keys in border.ts for better readability.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2020

🦋 Changeset detected

Latest commit: 213174b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 49 packages
Name Type
@chakra-ui/button Patch
@chakra-ui/layout Patch
@chakra-ui/modal Patch
@chakra-ui/styled-system Patch
@chakra-ui/tag Patch
@chakra-ui/react Patch
@chakra-ui/system Patch
@chakra-ui/props-docs Patch
@chakra-ui/test-utils Patch
chakra-cra Patch
gatsby-starter-default Patch
chakra-nextjs Patch
chakra-nextjs-ts Patch
@chakra-ui/docs Patch
@chakra-ui/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/bt141fagx
✅ Preview: https://chakra-ui-git-fork-mohamedsayed008-fix-rtl-feature.chakra-ui.now.sh

@segunadebayo
Copy link
Member

@all-contributors add @MohamedSayed008 for code

@allcontributors
Copy link
Contributor

@segunadebayo

I've put up a pull request to add @MohamedSayed008! 🎉

@segunadebayo segunadebayo merged commit 7eb46e5 into chakra-ui:develop Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants