Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: narrow theme types for defaultProps and ComponentMultiStyleConfig #3300

Merged
merged 2 commits into from Feb 6, 2021

Conversation

TimKolberger
Copy link
Contributor

📝 Description

Fixes

 Type '{ defaultProps: { focusBorderColor: string; }; }' is not assignable to type 'ComponentStyleConfig'.
        Property 'parts' is missing in type '{ defaultProps: { focusBorderColor: string; }; }' but required in type 'ComponentMultiStyleConfig'.

@TimKolberger TimKolberger added the Type: Bug 🐛 Something isn't working label Feb 6, 2021
@vercel
Copy link

vercel bot commented Feb 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/gdg030od1
✅ Preview: https://chakra-ui-git-fix-theme-types-default-props.chakra-ui.now.sh

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2021

🦋 Changeset detected

Latest commit: 83a3f78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@chakra-ui/react Patch
@chakra-ui/theme Patch
@chakra-ui/test-utils Patch
chakra-cra Patch
gatsby-starter-default Patch
chakra-nextjs Patch
chakra-nextjs-ts Patch
@chakra-ui/props-docs Patch
@chakra-ui/docs Patch
@chakra-ui/toast Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@segunadebayo segunadebayo merged commit 02ca2b7 into main Feb 6, 2021
@segunadebayo segunadebayo deleted the fix/theme-types-default-props branch February 6, 2021 12:20
@github-actions github-actions bot mentioned this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants