Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default theme type cast #3366

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Conversation

TimKolberger
Copy link
Contributor

Closes #3314

📝 Description

This PR removes the typecast of the default chakra theme to ChakraTheme.

Type Theme was replaced by DefaultChakraTheme in the last release. This PR brings it back again and deprecates DefaultChakraTheme.

ChakaTheme is the definition how a theme looks like. Theme and former DefaultChakraTheme are the exact types of the default chakra theme.

💣 Is this a breaking change (Yes/No):

No, it brings back a removed type.

@vercel
Copy link

vercel bot commented Feb 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/k22bezfa2
✅ Preview: https://chakra-ui-git-fix-theme-and-extend-types.chakra-ui.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2021

🦋 Changeset detected

Latest commit: 5a8d8c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@chakra-ui/theme Patch
@chakra-ui/react Patch
@chakra-ui/toast Patch
@chakra-ui/test-utils Patch
chakra-cra Patch
gatsby-starter-default Patch
chakra-nextjs Patch
chakra-nextjs-ts Patch
@chakra-ui/props-docs Patch
@chakra-ui/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TimKolberger TimKolberger added the Topic: TypeScript 🤠 Issues or PR related to TypeScript label Feb 11, 2021
@segunadebayo segunadebayo merged commit 3d2101b into main Feb 12, 2021
@segunadebayo segunadebayo deleted the fix/theme-and-extend-types branch February 12, 2021 02:25
@github-actions github-actions bot mentioned this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: TypeScript 🤠 Issues or PR related to TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type of default theme is not accurate because of typecast
2 participants