fix(tabs): do not unmount tab content when lazy #3763
Conversation
🦋 Changeset detectedLatest commit: 96fabe3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/7wxLi15y9Z93RA5gSUYqpCLD1pHv |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 96fabe3:
|
|
Hi @stellarhoof, Thanks for this. Want to update the test to match the new behavior? |
|
I saw the failed build but assumed it was something else. Didn't think you had such granular tests. 👍 |
|
@segunadebayo Done |
|
Great work! Sorry to bother you but if you could extend this update to the use-popover hook as well, that would be fantastic! It also uses the `isLazy prop. |
|
@segunadebayo I'll make a different PR for the popover then since you merged this one. |
fix(tabs): do not unmount tab content when lazy
Closes #3683
📝 Description
Tabs' isLazy behavior is now to mount on first select and never unmount.
⛳️ Current behavior (updates)
Current behavior is to unmount on navigating away from a tab.
🚀 New behavior
Tabs' isLazy behavior is now to mount on first select and never unmount.
💣 Is this a breaking change (Yes/No):
No