Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon-button): update IconButton to use theme borderRadius #4245

Merged
merged 2 commits into from
Jun 18, 2021
Merged

fix(icon-button): update IconButton to use theme borderRadius #4245

merged 2 commits into from
Jun 18, 2021

Conversation

matt-kinton
Copy link
Contributor

@matt-kinton matt-kinton commented Jun 17, 2021

Closes #4244

📝 Description

Makes the IconButton component use the themed borderRadius, not set to md.

⛳️ Current behavior (updates)

IconButton always has borderRadius: 'md' unless directly set or using the isRound prop.

🚀 New behavior

IconButton uses the themed default for the Button borderRadius.

💣 Is this a breaking change (Yes/No):

No

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2021

🦋 Changeset detected

Latest commit: ff946d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@chakra-ui/button Patch
@chakra-ui/react Patch
@chakra-ui/test-utils Patch
@chakra-ui/props-docs Patch
@chakra-ui/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/DXmKmVUkPK4tdpRTYRXmAg43Ac2t
✅ Preview: https://chakra-ui-git-fork-mattinton-patch-1-chakra-ui.vercel.app

[Deployment for ff946d7 failed]

@segunadebayo
Copy link
Member

@Mattinton, please include a changeset.

Here's how to do that:
image

@segunadebayo segunadebayo merged commit cc9b76f into chakra-ui:main Jun 18, 2021
@github-actions github-actions bot mentioned this pull request Jun 18, 2021
@matt-kinton matt-kinton deleted the patch-1 branch June 18, 2021 12:40
@matt-kinton
Copy link
Contributor Author

Thanks for adding the changeset @segunadebayo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IconButton does not use themed Button borderRadius
2 participants