fix(button): take left and right icons into consideration for button loading state

[dsumer]

📝 Description

This is a fix so that the left and right icon of a button also stay in the DOM while the button isLoading to avoid jumping button elements.

⛳️ Current behavior (updates)

Currently, the left and right icons of a button don't get rendered when the button is in the loading state, which leads to less width of the button, leading to unwanted layout shifts.

🚀 New behavior

The left and right icons also get rendered when the button is in the loading state and will be hidden with opacity 0 like the rest of the children.

💣 Is this a breaking change (Yes/No):

No

[changeset-bot]

🦋 Changeset detected

Latest commit: bafcc39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@chakra-ui/button	Patch
@chakra-ui/react	Patch
@chakra-ui/test-utils	Patch
@chakra-ui/props-docs	Patch
@chakra-ui/docs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/E2nCnXvQT5QddXGLr9naG3Wu9CEa
✅ Preview: Failed

[Deployment for bafcc39 failed]

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bafcc39:

Sandbox	Source
create-react-app-ts	Configuration

[with-heart]

Current: https://codesandbox.io/s/create-react-app-ts-forked-su1wr?file=/src/App.tsx
After this PR: https://codesandbox.io/s/create-react-app-ts-forked-kbfxe?file=/src/App.tsx

[with-heart]

I added a changeset file (.changeset/cold-guests-hug.md) so @chakra-ui/button will receive a version bump for this change and will generate a CHANGELOG entry.