-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add range-slider #4740
feat: add range-slider #4740
Conversation
🦋 Changeset detectedLatest commit: f659e74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). chakra-ui – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/9VpTRi4JoqHQgMjCwZdxxWRSFcXV chakra-ui-storybook – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/DCw6XuD84evKQmbty5xk5cjpHkf6 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f659e74:
|
chore: add range slider tests
📝 Description
This PR adds support for multi-thumb / range sliders. By definition, a multi-thumb slider is a slider with two or more thumbs that each set a value in a group of related values.
Learn more here: https://www.w3.org/TR/wai-aria-practices/#slidertwothumb
⛳️ Current behavior (updates)
We currently don't support range-slider.
🚀 New behavior
Now, we do ✌️
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
To make this happen, here's a breakdown of the tasks:
useRangeSlider
hook that handles most of the logic for multi-thumb slidersslider.utils
to ensure it can be shared betweenuseSlider
anduseRangeSlider
slider.tsx
to the theme so it can be shared withrange-slider.tsx
TODOS
isReversed
and RTL functionality works correctlygetOutputProps
to prop getters to allow user display slider values in their UI