Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add range-slider #4740

Merged
merged 18 commits into from
Oct 5, 2021
Merged

feat: add range-slider #4740

merged 18 commits into from
Oct 5, 2021

Conversation

segunadebayo
Copy link
Member

@segunadebayo segunadebayo commented Sep 20, 2021

📝 Description

This PR adds support for multi-thumb / range sliders. By definition, a multi-thumb slider is a slider with two or more thumbs that each set a value in a group of related values.

Learn more here: https://www.w3.org/TR/wai-aria-practices/#slidertwothumb

⛳️ Current behavior (updates)

We currently don't support range-slider.

🚀 New behavior

Now, we do ✌️

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

To make this happen, here's a breakdown of the tasks:

  • Create a useRangeSlider hook that handles most of the logic for multi-thumb sliders
  • Refactor slider.utils to ensure it can be shared between useSlider and useRangeSlider
  • Move all style-related stuff in slider.tsx to the theme so it can be shared with range-slider.tsx

TODOS

  • Ensure that isReversed and RTL functionality works correctly
  • Write docs for range slider
  • Write tests for range slider
  • Add more storybook for range slider
  • Add getOutputProps to prop getters to allow user display slider values in their UI

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2021

🦋 Changeset detected

Latest commit: f659e74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@chakra-ui/slider Minor
@chakra-ui/theme Patch
@chakra-ui/react Patch
@chakra-ui/toast Patch
@chakra-ui/test-utils Patch
@chakra-ui/props-docs Patch
@chakra-ui/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/9VpTRi4JoqHQgMjCwZdxxWRSFcXV
✅ Preview: https://chakra-ui-git-feat-range-slider-chakra-ui.vercel.app

chakra-ui-storybook – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/DCw6XuD84evKQmbty5xk5cjpHkf6
✅ Preview: https://chakra-ui-storybook-git-feat-range-slider-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f659e74:

Sandbox Source
create-react-app-ts Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants