Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): preventing drawer from disappearing on placement change #4744

Merged

Conversation

rohankokane
Copy link
Contributor

Closes #4729

📝 Description

Preventing drawer modal from disappearing on changing the placement value

⛳️ Current behavior (updates)

Drawer gets hidden if placement prop changes

🚀 New behavior

Now drawer doesn't get hidden and placement is changed accordingly

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Explicitly mentioning x and y values of enter and exit states for slide transition variants

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2021

🦋 Changeset detected

Latest commit: 930e6dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@chakra-ui/transition Patch
@chakra-ui/accordion Patch
@chakra-ui/menu Patch
@chakra-ui/modal Patch
@chakra-ui/react Patch
@chakra-ui/toast Patch
@chakra-ui/test-utils Patch
@chakra-ui/props-docs Patch
@chakra-ui/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/DmpjcyTqAmNoX3hiGGjYURFSTLaJ
✅ Preview: https://chakra-ui-git-fork-rohankokane-fix-4729-modal-7223c2-chakra-ui.vercel.app

chakra-ui-storybook – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/B7afgGEJaNZrGiZtN7AiiHVHGBWb
✅ Preview: https://chakra-ui-storybook-git-fork-rohankokane-fix-4-3b5fa2-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 21, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 930e6dc:

Sandbox Source
create-react-app-ts Configuration
dry-moon-dl7v3 Issue #4729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer disappears when placement changed while open
2 participants