Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add onCloseComplete prop to Modal #5402

Merged
merged 3 commits into from Mar 15, 2022

Conversation

ShumRain
Copy link
Contributor

Closes #

📝 Description

add onCloseComplete prop to Modal, it from support provided by AnimatePresence。

⛳️ Current behavior (updates)

I can't do something after the Modal close animation is over

🚀 New behavior

I can do something after the Modal close animation is over

💣 Is this a breaking change (Yes/No):

NO

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2022

🦋 Changeset detected

Latest commit: fbb7510

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@chakra-ui/modal Minor
@chakra-ui/react Patch
@chakra-ui/props-docs Patch
@chakra-ui/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/95f2rUzFQVgw91Ee8thD7jewzZqh
✅ Preview: https://chakra-ui-storybook-git-fork-shumrain-feat-mod-964f0e-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 18, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fbb7510:

Sandbox Source
create-react-app-ts Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants