Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switch): Change lineHeight from "normal" to 0 to remove a few extra pixels in … #5500

Merged
merged 2 commits into from Feb 5, 2022

Conversation

kk21
Copy link
Contributor

@kk21 kk21 commented Feb 1, 2022

…height at the bottom.

📝 Description

Change the lineHeight of the switch container to 0 so that inline child elements will not have extra pixels in height.

⛳️ Current behavior (updates)

There are a few extra pixels at the bottom of the switch for all the sizes.

🚀 New behavior

Removes a few extra pixels in height at the bottom of the switch for all the sizes.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

🦋 Changeset detected

Latest commit: 93f8ef3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@chakra-ui/switch Patch
@chakra-ui/react Patch
@chakra-ui/props-docs Patch
@chakra-ui/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/3zEijPbvFyA71d4JEid1aJFXFu81
✅ Preview: https://chakra-ui-storybook-git-fork-kk21-fix-switch-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 93f8ef3:

Sandbox Source
create-react-app-ts Configuration

@kk21 kk21 changed the title Change lineHeight from "normal" to 0 to remove a few extra pixels in … fix(switch): Change lineHeight from "normal" to 0 to remove a few extra pixels in … Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants