New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow all dom elements for the chakra factory #5508
Conversation
🦋 Changeset detectedLatest commit: b98f89b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/Ank8TniCjfxRRtgLuwPVAghr9nnm |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b98f89b:
|
📦 A new release has been made for this pull requestTo play around with this release, you can install
|
28c4bd9
to
76dc3c8
Compare
] as const | ||
|
||
export type DOMElements = UnionStringArray<typeof domElements> | ||
export type DOMElements = keyof JSX.IntrinsicElements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a breath of fresh air! Thanks for working on this
📝 Description
Allow all
JSX.IntrinsicElements
for the chakra factory. This allows to use every DOM element with the shorthand version:⛳️ Current behavior (updates)
It's a hardcoded list
🚀 New behavior
It derives the types from
JSX.IntrinsicElements
and resolves the components lazy with aProxy
and aMap
as cache.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
MDN Proxy