New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use sorted breakpoints in useBreakpoint #5576
Conversation
🦋 Changeset detectedLatest commit: 60fc221 The changes in this PR will be included in the next version bump. This PR includes changesets to release 55 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/8YjM5VTKdpWhY8Sr8whUacvjiAPU |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 60fc221:
|
📦 A new release has been made for this pull requestTo play around with this release, you can install
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Just before merging I reviewed the file again, and I did not understand immediately what was going on. So I rewrote the whole hook and reused the breakpoint logic from the theme breakpoints. And I fixed a bug on the way there. Can I request a review again @nikolovlazar and @cschroeter? 💖 |
Closes 5555 (not yet. The CSS responsive object uses media min queries, where as the useBreakpoint uses minmax queries)
📝 Description
Fixed an issue where the hook
useBreakpoint
did not work as expected with custom breakpoints⛳️ Current behavior (updates)
useBreakpoint used user defined values from the theme. It is operating on an unsorted object.
🚀 New behavior
It uses the processed and sorted breakpoints from
toCSSVar(theme)
.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information