Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zIndex of a elevated link in a linkoverlay #5910

Closed
wants to merge 1 commit into from

Conversation

wutje
Copy link

@wutje wutje commented Apr 21, 2022

#5632 was solved by changing the zIndex of the linkbox, however the elevated link it self was not updated. This breaks if the elevated link is before the overlay link in the DOM.

For example:

<LinkBox as='article'>
  <a href='#notworking'>
    Link not working
  </a>
  <Heading>
    <LinkOverlay href='#overlay'>
      Overlay link
    </LinkOverlay>
  </Heading>
  <a href='#working'>
    Link working
  </a>
</LinkBox>

chakra-ui#5632 was solved by changing the zIndex of the linkbox, however the elevated link it self was not updated. This breaks if the elevated link is before the overlay link in the DOM.
@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2022

⚠️ No Changeset found

Latest commit: 0d45306

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chakra-ui-storybook ✅ Ready (Inspect) Visit Preview Apr 21, 2022 at 10:40AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d45306:

Sandbox Source
create-react-app-ts Configuration

@hornta
Copy link

hornta commented Apr 23, 2022

Does this fix #5918 ?

@m4x3d
Copy link
Contributor

m4x3d commented May 3, 2022

Hey @wutje, thanks for opening that PR and sorry that you had problems with that component after my changes.

As I discussed with @TimKolberger in #5918 we will revert my changes. Will be done with #5964.

@wutje
Copy link
Author

wutje commented May 4, 2022

My code base worked before this change so I am happy with the revert. Thank you for taking the time to fix this.

@segunadebayo
Copy link
Member

I just merged the PR that reverts the changes by @m4x3d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants