Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing JSDocs and Docsite Links #6666

Merged
merged 6 commits into from Sep 12, 2022

Conversation

TylerAPfledderer
Copy link
Collaborator

@TylerAPfledderer TylerAPfledderer commented Sep 10, 2022

📝 Description

Ensures that all Components, functions, and hooks that have detailed pages on the Chakra site have corresponding JSDocs and links back to the docsite via IDE intellisense.

Includes add/fixing links to related WAI-ARIA patterns.

⛳️ Current behavior (updates)

Some components, hooks, and functions did not have JSDocs and/or links back to their corresponding pages of the Chakra docsite.

🚀 New behavior

All components, hooks, and functions with corresponding docsite pages will now have JSDocs and site links for IDE intellisense viewing.

💣 Is this a breaking change (Yes/No):

No, as this does not change any functionality of the package.

📝 Additional Information

This is to help provide more accessibility of the package within the user's IDE. Only some of the components had JSDocs with site links.

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2022

🦋 Changeset detected

Latest commit: 7d25775

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@chakra-ui/alert Patch
@chakra-ui/button Patch
@chakra-ui/checkbox Patch
@chakra-ui/close-button Patch
@chakra-ui/editable Patch
@chakra-ui/form-control Patch
@chakra-ui/icon Patch
@chakra-ui/input Patch
@chakra-ui/layout Patch
@chakra-ui/media-query Patch
@chakra-ui/menu Patch
@chakra-ui/modal Patch
@chakra-ui/pin-input Patch
@chakra-ui/popover Patch
@chakra-ui/radio Patch
@chakra-ui/select Patch
@chakra-ui/skeleton Patch
@chakra-ui/skip-nav Patch
@chakra-ui/stat Patch
@chakra-ui/switch Patch
@chakra-ui/system Patch
@chakra-ui/table Patch
@chakra-ui/tabs Patch
@chakra-ui/toast Patch
@chakra-ui/visually-hidden Patch
@chakra-ui/react-use-controllable-state Patch
@chakra-ui/react-use-disclosure Patch
@chakra-ui/hooks Patch
@chakra-ui/react Patch
@chakra-ui/accordion Patch
@chakra-ui/number-input Patch
@chakra-ui/tooltip Patch
@chakra-ui/textarea Patch
@chakra-ui/icons Patch
@chakra-ui/tag Patch
@chakra-ui/provider Patch
@chakra-ui/slider Patch
@chakra-ui/props-docs Patch
@chakra-ui/storybook-addon Patch
@chakra-ui/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chakra-ui-storybook ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 0:03AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d25775:

Sandbox Source
create-react-app-ts Configuration

@segunadebayo segunadebayo merged commit 3e1b3f6 into chakra-ui:main Sep 12, 2022
@github-actions github-actions bot mentioned this pull request Sep 12, 2022
@TylerAPfledderer TylerAPfledderer deleted the docs/ts-add-doc-links branch September 12, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants