fix(utils): reduce gaps in media queries for breakpoints #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e00ca5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Ran into this issue, what needs to be done to get this merged? |
segunadebayo
force-pushed
the
fix/breakpoint-calculation
branch
from
2e6cef0
to
0e00ca5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6743
📝 Description
Fixes useBreakpointValue and useBreakpoint hooks by reducing the gaps in the hooks' media queries. These gaps excluded certain viewport widths.
⛳️ Current behavior (updates)
Media queries generated from theme breakpoints do not cover certain viewport widths due to the 1px and .0625em gaps.
🚀 New behavior
Media queries generated from theme breakpoints cover almost all viewport widths by reducing the gaps to .02px and .01em.
💣 Is this a breaking change (Yes/No):
NoIt looks like this PR being refactored broke the hook(s) in Firefox due to the gaps for em being changed to be smaller. The core team member who fixed it says to use
@chakra-ui/react@2.4.7