revert(gatsby-plugin): revert implementation of baseTheme
#7525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 873a588 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7179
📝 Description
This PR reverts the Gatsby plugin back to the version prior to adding the
ChakraBaseProvideras an option with thebaseTheme.This is a two-fold change
⛳️ Current behavior (updates)
Console warning
Attempted import error: 'baseTheme' is not exported from './theme' (imported as 'baseTheme')when attempting to useextendBaseThemein the project🚀 New behavior
Warning is gone because the
baseThemeimport is removed from the plugin.💣 Is this a breaking change (Yes/No):
No. Use of the
extendBaseThemeis still valid, and only the added optionisBaseProvideris removed.📝 Additional Information
In using the added features of
extendBaseThemeandChakraBaseProviderand from the discussion in the related issue, the provider seems unnecessary.With the component default theming stripped away initially from
ChakraBaseProvider, the user might already be inclined to create custom theming. In doing so, withextendThemeorextendBaseTheme, the merging of thethemeorbaseThemeobjects from the respective functions into the custom theming will override whatever object is initially rendered in the provider.So long as the user uses
extendBaseTheme, the entire set of default component theme will not be apart of the payload aside from defaults the user decides to import.