Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make use-image respect crossOrigin property #7553

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

AlphaNecron
Copy link
Contributor

@AlphaNecron AlphaNecron commented Apr 8, 2023

fix: make use-image respect crossOrigin property in order to avoid errors when loading image without CORS, leading to false status.

Closes #

📝 Description

Make use-image hook respect crossOrigin property in order to avoid errors when loading image without CORS, leading to false status.

⛳️ Current behavior (updates)

use-image hook fails to get image when not specifying crossOrigin property and eventually be blocked by CORS policy.

🚀 New behavior

Allow use-image hook to use crossOrigin property when loading image.

💣 Is this a breaking change (Yes/No):

No.

📝 Additional Information

fix: make use-image respect crossOrigin property in order to avoid errors when loading image without CORS, leading to false status.
@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2023

🦋 Changeset detected

Latest commit: 25b354e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chakra-ui/avatar Patch
@chakra-ui/image Patch
@chakra-ui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chakra-ui-storybook ✅ Ready (Inspect) Visit Preview Apr 17, 2023 2:30pm

@AlphaNecron
Copy link
Contributor Author

Can you add a changeset for me? My network connection is so fluctuating that pulling npm packages takes forever 👀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants