fix(menu): update menu z-index for defined dropdown theme variable #8121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 716aec7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📝 Description
Modifies the
Menutheme properties to use the variabledropdownfor z-indices, which is defined in the theme here: https://chakra-ui.com/docs/styled-system/theme#z-index-values.⛳️ Current behavior (updates)
The Menu's z-index property is currently hardcoded to "1", which would sometimes cause open menu elements to appear behind other z-indexed elements.
🚀 New behavior
Menu's elements inherit the proper z-index value, making it more difficult to accidentally appear behind other UI elements.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Tested / verified this update locally in Storybook.
I didn't see an issue filed for this specifically, but it was close enough to this issue. If dedicated issues are preferred, let me know and I can create one.
#7778