AspectRatio still does not apply the ratio value

[omarkhatibco]

Description

Hey again,

I just tried the new AspectRatio pattern after the last bug, right now only the padding-bottom value is not working.

it works if I don't provide a value and it use the default one 4 / 3 but when I provide something else such as 16 / 9 or even 1 / 2, I see the generated class but it does not apply for some reason

Link to Reproduction

here

Steps to reproduce

Check Aspect Ratio component

JS Framework

React TS

Panda CSS Version

0.6.0

Browser

Latest

Operating System

• macOS
• Windows
• Linux

Additional Information

No response

[astahmer]

my bad my bad, thanks for catching this (again)

[omarkhatibco]

Hey @astahmer,

I'm sorry to inform you that it's still not working 🙈
check the codesandbox here

[astahmer]

It was ! It even is still working in the tests.. I even tried pasting your exact sample

---

We use ts-evaluator for those cases instead of a simple eval, as a BinaryExpression could contain TS specific syntax like 1 + (2 as number) etc

So I tried debugging the issue using your repo and I found that the typescript node.kind (223) on the BinaryExpression (16 / 7) wasn't matching the one from your typescript version 5.1.6 (which is also the one we use in the panda repo)

Then I found out we (in panda repo) have upgraded the TS version to 5.1.6 without upgrading ts-morph to 19.0.0 which support 5.1, so there is a mismatch since our ts-morph is at 18.0.8 which only supports 5.0.2

After that I tried updating ts-morph in my local panda repo and despite having the correct node.kind (225), ts-evaluator utility function isExpression is still returning false when encoutering BinaryExpression

My final guess is that ts-evaluator fails because of the exact same reasons listed above, it only supports until typescript: 4.9.4

I'm not sure why it works in the tests tho ? also, not sure how to resolve that (and the future issues that will arise if ts-evaluator isn't updated 😢 )

[omarkhatibco]

@astahmer,
No worries, I just wanted to mention the issue, for now, I could fix maybe using css vars

could you please reopen the issue so I can keep tracking it?

[astahmer]

yes ofc, and thank you as usual for reporting those, it helps a lot! 🙏

[astahmer]

this should be fine once #1055 gets merged

[omarkhatibco]

Hey @astahmer, I can confirm that it's working now, thanks for your help