-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: token/utility/codegen hooks #2094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8a41b6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
test: allow passing custom hooks refactor: dict.formatTokenName refactor: use array of string as path rather than dot-delimited string for colorPalette -> so that the formatTokenName can be replaced with custom logic with hooks, we couldnt before because the join('.') logic was hardcoded everywhere
astahmer
force-pushed
the
feat/token-hooks
branch
from
January 27, 2024 01:59
1d03332
to
243ad92
Compare
segunadebayo
reviewed
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2056
Closes #1848
📝 Description
Introduce 3 new hooks:
tokens:created
This hook is called when the token engine has been created. You can use this hook to add your format token names and
variables.
utility:created
This hook is called when the internal classname engine has been created. You can override the default
toHash
functionused when
config.hash
is set totrue
codegen:prepare
This hook is called right before writing the codegen files to disk. You can use this hook to tweak the codegen files
💣 Is this a breaking change (Yes/No):
no
📝 Additional Information
With those hooks, the features from the two mentioned PR should be possible without introducing new config options or changing much about Panda internals