Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styled nested composition with cva #2192

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

astahmer
Copy link
Collaborator

📝 Description

Fix styled factory nested composition with cva

const Button = styled("button", { ... });
const PageButton = styled(Button, { ... }); // this was correctly merging the styles from Button+PageButton 
const SectionButton = styled(PageButton, { ... }); // this was not merging the styles from Button+PageButton+SectionButton correctly

💣 Is this a breaking change (Yes/No):

somewhat, this worked fine for the 1st merging but not afterwards, it works as expected now

Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: e5a81d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@pandacss/generator Patch
@pandacss/config Patch
@pandacss/types Patch
@pandacss/node Patch
@pandacss/fixture Patch
@pandacss/parser Patch
@pandacss/dev Patch
@pandacss/studio Patch
@pandacss/core Patch
@pandacss/logger Patch
@pandacss/preset-atlaskit Patch
@pandacss/preset-base Patch
@pandacss/preset-open-props Patch
@pandacss/preset-panda Patch
@pandacss/token-dictionary Patch
@pandacss/astro-plugin-studio Patch
@pandacss/postcss Patch
@pandacss/extractor Patch
@pandacss/is-valid-prop Patch
@pandacss/shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Feb 12, 2024 10:21am
panda-playground ✅ Ready (Inspect) Visit Preview Feb 12, 2024 10:21am
panda-studio ✅ Ready (Inspect) Visit Preview Feb 12, 2024 10:21am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants