Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: utility group #2269

Merged
merged 2 commits into from
Feb 27, 2024
Merged

feat: utility group #2269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f596a9
feat: utility group
astahmer Feb 26, 2024
80912db
chore: singular format / more groups
astahmer Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/silly-olives-unite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@pandacss/preset-base': patch
'@pandacss/types': patch
---

Add a `group` to every utility in the `@pandacss/preset-base`, this helps Panda tooling organize utilities.
4 changes: 2 additions & 2 deletions packages/generator/__tests__/generate-css-fn.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

26 changes: 13 additions & 13 deletions packages/generator/__tests__/generate-prop-types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ describe('generate property types', () => {
insetInlineStart: Tokens["spacing"];
right: Tokens["spacing"];
bottom: Tokens["spacing"];
insetX: Tokens["spacing"] | CssProperties["insetInline"];
insetY: Tokens["spacing"] | CssProperties["insetBlock"];
float: "left" | "right" | "start" | "end";
hideFrom: Tokens["breakpoints"];
hideBelow: Tokens["breakpoints"];
Expand Down Expand Up @@ -105,7 +103,7 @@ describe('generate property types', () => {
textShadowColor: Tokens["colors"];
textWrap: "wrap" | "balance" | "nowrap";
truncate: boolean;
listStyleImage: Tokens["assets"];
listStyleImage: Tokens["assets"];
background: Tokens["colors"];
backgroundColor: Tokens["colors"];
backgroundImage: Tokens["assets"];
Expand Down Expand Up @@ -186,8 +184,6 @@ describe('generate property types', () => {
caretColor: Tokens["colors"];
scrollbar: "visible" | "hidden";
scrollMargin: Tokens["spacing"];
scrollMarginX: Tokens["spacing"] | CssProperties["scrollMarginInline"];
scrollMarginY: Tokens["spacing"] | CssProperties["scrollMarginBlock"];
scrollMarginLeft: Tokens["spacing"];
scrollMarginRight: Tokens["spacing"];
scrollMarginTop: Tokens["spacing"];
Expand All @@ -205,8 +201,6 @@ describe('generate property types', () => {
scrollPaddingInline: Tokens["spacing"];
scrollPaddingInlineEnd: Tokens["spacing"];
scrollPaddingInlineStart: Tokens["spacing"];
scrollPaddingX: Tokens["spacing"] | CssProperties["scrollPaddingInline"];
scrollPaddingY: Tokens["spacing"] | CssProperties["scrollPaddingBlock"];
scrollPaddingLeft: Tokens["spacing"];
scrollPaddingRight: Tokens["spacing"];
scrollPaddingTop: Tokens["spacing"];
Expand Down Expand Up @@ -237,6 +231,8 @@ describe('generate property types', () => {
export interface PropertyTypes extends PropertyValueTypes {

pos: Shorthand<"position">;
insetX: Shorthand<"insetInline">;
insetY: Shorthand<"insetBlock">;
insetEnd: Shorthand<"insetInlineEnd">;
end: Shorthand<"insetInlineEnd">;
insetStart: Shorthand<"insetInlineStart">;
Expand Down Expand Up @@ -323,6 +319,10 @@ describe('generate property types', () => {
shadowColor: Shorthand<"boxShadowColor">;
x: Shorthand<"translateX">;
y: Shorthand<"translateY">;
scrollMarginY: Shorthand<"scrollMarginBlock">;
scrollMarginX: Shorthand<"scrollMarginInline">;
scrollPaddingY: Shorthand<"scrollPaddingBlock">;
scrollPaddingX: Shorthand<"scrollPaddingInline">;
}

type StrictableProps =
Expand Down Expand Up @@ -449,8 +449,6 @@ describe('generate property types', () => {
insetInlineStart: Tokens["spacing"];
right: Tokens["spacing"];
bottom: Tokens["spacing"];
insetX: Tokens["spacing"];
insetY: Tokens["spacing"];
float: "left" | "right" | "start" | "end";
hideFrom: Tokens["breakpoints"];
hideBelow: Tokens["breakpoints"];
Expand Down Expand Up @@ -604,8 +602,6 @@ describe('generate property types', () => {
caretColor: Tokens["colors"];
scrollbar: "visible" | "hidden";
scrollMargin: Tokens["spacing"];
scrollMarginX: Tokens["spacing"];
scrollMarginY: Tokens["spacing"];
scrollMarginLeft: Tokens["spacing"];
scrollMarginRight: Tokens["spacing"];
scrollMarginTop: Tokens["spacing"];
Expand All @@ -623,8 +619,6 @@ describe('generate property types', () => {
scrollPaddingInline: Tokens["spacing"];
scrollPaddingInlineEnd: Tokens["spacing"];
scrollPaddingInlineStart: Tokens["spacing"];
scrollPaddingX: Tokens["spacing"];
scrollPaddingY: Tokens["spacing"];
scrollPaddingLeft: Tokens["spacing"];
scrollPaddingRight: Tokens["spacing"];
scrollPaddingTop: Tokens["spacing"];
Expand Down Expand Up @@ -655,6 +649,8 @@ describe('generate property types', () => {
export interface PropertyTypes extends PropertyValueTypes {

pos: Shorthand<"position">;
insetX: Shorthand<"insetInline">;
insetY: Shorthand<"insetBlock">;
insetEnd: Shorthand<"insetInlineEnd">;
end: Shorthand<"insetInlineEnd">;
insetStart: Shorthand<"insetInlineStart">;
Expand Down Expand Up @@ -741,6 +737,10 @@ describe('generate property types', () => {
shadowColor: Shorthand<"boxShadowColor">;
x: Shorthand<"translateX">;
y: Shorthand<"translateY">;
scrollMarginY: Shorthand<"scrollMarginBlock">;
scrollMarginX: Shorthand<"scrollMarginInline">;
scrollPaddingY: Shorthand<"scrollPaddingBlock">;
scrollPaddingX: Shorthand<"scrollPaddingInline">;
}

type StrictableProps =
Expand Down
17 changes: 17 additions & 0 deletions packages/preset-base/src/utilities/background.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,28 @@ export const background: UtilityConfig = {
backgroundPosition: {
shorthand: 'bgPosition',
className: 'bg',
group: 'Background',
},
backgroundPositionX: {
shorthand: 'bgPositionX',
className: 'bg-x',
group: 'Background',
},
backgroundPositionY: {
shorthand: 'bgPositionY',
className: 'bg-y',
group: 'Background',
},

backgroundAttachment: {
shorthand: 'bgAttachment',
className: 'bg',
group: 'Background',
},
backgroundClip: {
shorthand: 'bgClip',
className: 'bg-clip',
group: 'Background',
transform(value) {
return {
backgroundClip: value,
Expand All @@ -33,39 +38,47 @@ export const background: UtilityConfig = {
shorthand: 'bg',
className: 'bg',
values: 'colors',
group: 'Background',
transform: createColorMixTransform('background'),
},
backgroundColor: {
shorthand: 'bgColor',
className: 'bg',
values: 'colors',
group: 'Background',
transform: createColorMixTransform('backgroundColor'),
},

backgroundOrigin: {
shorthand: 'bgOrigin',
className: 'bg-origin',
group: 'Background',
},
backgroundImage: {
shorthand: 'bgImage',
className: 'bg-img',
values: 'assets',
group: 'Background',
},
backgroundRepeat: {
shorthand: 'bgRepeat',
className: 'bg-repeat',
group: 'Background',
},
backgroundBlendMode: {
shorthand: 'bgBlendMode',
className: 'bg-blend',
group: 'Background',
},
backgroundSize: {
shorthand: 'bgSize',
className: 'bg',
group: 'Background',
},
backgroundGradient: {
shorthand: 'bgGradient',
className: 'bg-gradient',
group: 'Background',
values(theme) {
return {
...theme('gradients'),
Expand All @@ -89,6 +102,7 @@ export const background: UtilityConfig = {
},
textGradient: {
className: 'text-gradient',
group: 'Background',
values(theme) {
return {
...theme('gradients'),
Expand All @@ -115,16 +129,19 @@ export const background: UtilityConfig = {
gradientFrom: {
className: 'from',
values: 'colors',
group: 'Background',
transform: createColorMixTransform('--gradient-from'),
},
gradientTo: {
className: 'to',
values: 'colors',
group: 'Background',
transform: createColorMixTransform('--gradient-to'),
},
gradientVia: {
className: 'via',
values: 'colors',
group: 'Background',
transform(value, args) {
const transformed = gradientVia(value, args)
return {
Expand Down
Loading
Loading