Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify typings, add csstype comments to SystemProperties #2347

Merged
merged 10 commits into from
Mar 15, 2024

Conversation

astahmer
Copy link
Collaborator

📝 Description

  • Simplify typings for the style properties.
  • Add the csstype comments for each property.

You will now be able to see a utility or csstype values in 2 clicks !


Instead of relying on TS to infer the correct type for each properties, we now just generate the appropriate value for
each property based on the config.

This should make it easier to understand the type of each property and might also speed up the TS suggestions as there's
less to infer.

💣 Is this a breaking change (Yes/No):

no

📝 Additional Information

before:

typings-before.mp4

after:

typings-after.mp4

Copy link

changeset-bot bot commented Mar 10, 2024

🦋 Changeset detected

Latest commit: 82d5236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@pandacss/is-valid-prop Minor
@pandacss/generator Minor
@pandacss/studio Minor
@pandacss/types Minor
@pandacss/core Minor
@pandacss/fixture Minor
@pandacss/node Minor
@pandacss/parser Minor
@pandacss/dev Minor
@pandacss/config Minor
@pandacss/logger Minor
@pandacss/preset-atlaskit Minor
@pandacss/preset-base Minor
@pandacss/preset-open-props Minor
@pandacss/preset-panda Minor
@pandacss/token-dictionary Minor
@pandacss/astro-plugin-studio Minor
@pandacss/postcss Minor
@pandacss/extractor Minor
@pandacss/shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Mar 15, 2024 9:55am
panda-playground ✅ Ready (Inspect) Visit Preview Mar 15, 2024 9:55am
panda-studio ✅ Ready (Inspect) Visit Preview Mar 15, 2024 9:55am

@astahmer astahmer marked this pull request as ready for review March 10, 2024 11:33
@astahmer astahmer changed the title refactor: remove layers of typings, add csstype comments to SystemProperties refactor: simplify typings, add csstype comments to SystemProperties Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants